Repository navigation
Conversation
A missing container became an array whenever the next token was < Infinity, so tokens like -1, 1.5, 01, 0x1f or ' ' were written as named properties on an array and lost in JSON. Follow RFC 6901: only 0, digits without a leading zero, or - make an array. Fixes janl#68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68.
setmade a missing container an array when the next token was< Infinity. That is true for-1,1.5,01,0x1f,1e3and' ', so the value went onto an array as a named property andJSON.stringifydropped it ({"a":[]}).Now an array is only created when the next token is an RFC 6901 array index:
0, digits without a leading zero, or-. Everything else gets an object. Number tokens in array pointers still work (['', 'a', 0, 'b']→{"a":[{"b":1}]}).Tests: new cases in
test.jsfor both kinds of tokens. They fail on main and pass with the change.npm test(standard + tests) is green.